Update build.sh #164
Open
Update build.sh #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatever cleans the workspace where the tree is cloned apparently just does `rm -rf *` which does not delete .foo, and in particular the .python-shebangs file from previous build in this workspace
|
I'd like to add this to the code that actually does the clean up rather than here. That's in build-jobs on Gerrit. |
|
That'd be my preference too. I looked for something like that, but it's too well hidden. So you fixed it there already? (Where ever that is?) And I can't find anything named build-jobs in gerrit. (I see the build-job task in jenkins.) I see the cleanup.sh script that cleans most things. Do we really just keep cloning into the same directory without ever doing an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whatever cleans the workspace where the tree is cloned apparently just does
rm -rf *which does not delete .foo, and in particular the .python-shebangs file from previous build in this workspace